On Mon, Jul 29, 2019 at 04:04:38PM +0200, Dmitry Torokhov wrote: > On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote: > > If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m > > building fails: > > > > drivers/input/keyboard/applespi.o: In function `applespi_probe': > > applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext' > > > > Wrap it in LEDS_CLASS macro to fix this. > > No, we should add "depends on LEDS_CLASS" to the Konfig instead. While the loss of keyboard-backlight functionality is certainly not critical, in practice when building a kernel for desktops/laptops (i.e. where this module would be used) I see no real reason why you'd not have/want LEDS_CLASS enabled. So I'd agree with Dmitry that a Kconfig depends-on is probably the preferred approach. Cheers, Ronald
