Re: [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 27, 2019 at 02:01:26PM +0200, Maximilian Luz wrote:
> On 7/27/19 11:14 AM, Dmitry Torokhov wrote:
> > On Sat, Jul 20, 2019 at 05:05:11PM +0200, Maximilian Luz wrote:
> > > -
> > > -	error = gpiod_count(dev, NULL);
> > > -	if (error < 0) {
> > > -		dev_dbg(dev, "no GPIO attached, ignoring...\n");
> > > -		return -ENODEV;
> > 
> > I do not think we need to move this into individual "check" functions.
> > It is needed in all cases so we should keep it here.
> > 
> > How about version below?
> 
> Makes sense, looks good to me!

OK, great, applied.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux