Hi Dmitry, On Sun, Jul 21, 2019 at 10:24:27AM +0300, Dmitry Torokhov wrote: > On Sun, Jul 21, 2019 at 12:06:29AM -0700, Ronald Tschalär wrote: > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > Signed-off-by: Ronald Tschalär <ronald@xxxxxxxxxxxxx> > > --- > > drivers/input/keyboard/applespi.c | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c > > index d5defdefbc34..00cd8dccd4f5 100644 > > --- a/drivers/input/keyboard/applespi.c > > +++ b/drivers/input/keyboard/applespi.c > > @@ -998,10 +998,14 @@ static inline int le16_to_int(__le16 x) > > static void applespi_debug_update_dimensions(struct applespi_data *applespi, > > const struct tp_finger *f) > > { > > - applespi->tp_dim_min_x = min_t(int, applespi->tp_dim_min_x, f->abs_x); > > Should we also make tp_dim_* u16? Then we won't need min_t here. abs_x/abs_y are actually signed values and sometimes negative, and hence tp_dim_min_* are negative here. But we can just replace the min_t/max_t with min/max, since both args are now int's. Cheers, Ronald