On Thu, Jul 18, 2019 at 1:40 PM Life is hard, and then you die <ronald@xxxxxxxxxxxxx> wrote: > On Thu, Jul 18, 2019 at 10:06:54AM +0800, YueHaibing wrote: > > @@ -74,7 +74,7 @@ config ATARI_KBD_CORE > > config KEYBOARD_APPLESPI > > tristate "Apple SPI keyboard and trackpad" > > depends on ACPI && EFI > > - depends on SPI > > + depends on SPI && PCI > > depends on X86 || COMPILE_TEST > > imply SPI_PXA2XX > > imply SPI_PXA2XX_PCI > > -- > > 2.7.4 > > I think this is more properly fixed by Dmitry's suggestion of making > SPI_PXA2XX_PCI depend on PCI, since it's that module, not applespi, > that actually needs PCI - see > https://www.spinics.net/lists/linux-input/msg62351.html I'll put that into my randconfig setup to see if it's sufficient. I'm a little bit suspicious as the circular dependency was not avoided by the 'depends on X86' for MFD_INTEL_LPSS_PCI. Arnd
