Hi Dmitry, > Hi Lukasz, > > On Wed, Jul 17, 2019 at 10:17:04AM +0200, Lukasz Majewski wrote: > > Hi Dmitry, > > > > > On Wed, Jul 17, 2019 at 12:19:29AM +0200, Lukasz Majewski wrote: > > > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > > > > > > > The mc34708 has a different bit to enable pen detection. This > > > > adds the driver data and devtype necessary to probe the device > > > > and to distinguish between the mc13783 and the mc34708. > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > > > Signed-off-by: Lukasz Majewski <lukma@xxxxxxx> > > > > > > > > --- > > > > Changes for v3: > > > > - Replace forward declaration of mc13xxx_driver_data with > > > > structure definition > > > > - Rename mc13xxx_driver_data with mc13xxx_chip > > > > - Move static struct mc13xxx_chip mc13783_chip and mc34708_chip > > > > closer to ID table > > > > - Do not check mc13xxx device type > > > > > > You do not even need to define or store the type. Once it is > > > dropped please feel free to add > > > > Ok. I will remove the type definition. > > > > > > > > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > > > > > and merge with the other 2 patches. > > > > > > > Ok. I will squash those three patches into a single one, add your > > Acked-by and wait for Lee to pull this single patch to his MFD > > tree. > > Sorry, it looks like there is misunderstanding. I did not ask to > squash together the 3 patches, I meant that they can all go together > through the same tree (MFD). That is what I meant by them being > merged together. > Thanks for the explanation. > Sorry for being unclear. No problem - big thanks for very prompt review. > > Thanks. > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx
Attachment:
pgpae2fRy6XK0.pgp
Description: OpenPGP digital signature