Re: [input:next 2293/2295] drivers/spi/spi-pxa2xx-pci.c:245:11: warning: assignment makes pointer from integer without a cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 17, 2019 at 08:03:13AM +0800, kbuild test robot wrote:
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/dtor/input.git next
> head:   5a4cee7b28ed3ce4ce5980503926d5bc23c9c8d1
> commit: b426ac0452093da54206e021af72c979d01aa417 [2293/2295] Input: add Apple SPI keyboard and trackpad driver
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout b426ac0452093da54206e021af72c979d01aa417
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=ia64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/spi/spi-pxa2xx-pci.c: In function 'pxa2xx_spi_pci_probe':
>    drivers/spi/spi-pxa2xx-pci.c:245:13: error: implicit declaration of function 'clk_register_fixed_rate'; did you mean 'pci_register_io_range'? [-Werror=implicit-function-declaration]
>      ssp->clk = clk_register_fixed_rate(&dev->dev, buf , NULL, 0,
>                 ^~~~~~~~~~~~~~~~~~~~~~~
>                 pci_register_io_range
> >> drivers/spi/spi-pxa2xx-pci.c:245:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>      ssp->clk = clk_register_fixed_rate(&dev->dev, buf , NULL, 0,
>               ^
>    drivers/spi/spi-pxa2xx-pci.c:260:3: error: implicit declaration of function 'clk_unregister'; did you mean 'class_unregister'? [-Werror=implicit-function-declaration]
>       clk_unregister(ssp->clk);
>       ^~~~~~~~~~~~~~
>       class_unregister
>    cc1: some warnings being treated as errors

It looks to me that SPI_PXA2XX_PCI dependency is not strong enough, and
it should be

	def_tristate SPI_PXA2XX
	depends on PCI && COMMON_CLK

since if wither of those is off the driver is not going to work.

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux