On Monday 15 July 2019 10:10:42 Dmitry Torokhov wrote:
> Hi Hui,
>
> On Mon, Jul 08, 2019 at 10:24:58AM +0800, Hui Wang wrote:
> > + if ((param[0] == TP_VARIANT_ALPS) && (param[1] & 0x20)) {
> > + if (IS_ENABLED(MOUSE_PS2_TRACKPOINT))
> > + psmouse_dbg(psmouse,
> > + "ALPS CS19 trackpoint-only device detected, not using ALPS touchpad driver\n");
> > + else
> > + psmouse_warn(psmouse,
> > + "ALPS CS19 trackpoint-only device detected but MOUSE_PS2_TRACKPOINT not enabled, fallback to bare PS/2 mouse\n");
>
> I do not think that trackpoint driver not being enabled deserves a
> warning, especially coming from unrelated driver. As far as I understand
> the device still works reasonably well when handled as generic mouse.
>
> I condensed both messages down to "ALPS CS19 trackpoint-only device
> detected, ignoring", moved it down to alps_is_cs19_trackpoint() call
> site, and applied the patch.
>
> Keeping Pali's reviewed-by as the core idea of the patch has not
> changed.
>
> Thanks.
>
Ok, I'm fine with it. Debug message is still a good idea for debugging
purposes, why alps.c decided to not handle particular ALPS device.
--
Pali Rohár
pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
