On Tue, Jul 2, 2019 at 10:39 AM Bastien Nocera <hadess@xxxxxxxxxx> wrote: > > On Tue, 2019-07-02 at 10:29 +0200, Benjamin Tissoires wrote: > > drivers/hid/hid-creative-sb0540.c: In function > > 'creative_sb0540_raw_event': > > drivers/hid/hid-creative-sb0540.c:157:3: error: label 'out' used but > > not defined > > 157 | goto out; > > | ^~~~ > > > > It would have been nice to at least try to compile it in a tree. > > You don't need to compile the whole tree: just clone it, apply your > > patch and then `make -j4 M=drivers/hid` > > v4 _did_ build. Don't be surprised if after 4 versions on top of the > ones you did when the driver was out of tree, I get review fatigue, go > for expediency and some mistakes slip through. Right, sorry. > > Fixed in v6. > Thanks! Cheers, Benjamin
