On Sun, Jun 30, 2019 at 10:05 AM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > On Sun, Jun 23, 2019 at 10:59:18AM +0300, Andy Shevchenko wrote: > > On Sun, Jun 23, 2019 at 9:31 AM Dmitry Torokhov > > <dmitry.torokhov@xxxxxxxxx> wrote: > > > > > > Now that input_mt_report_slot_state() returns true if slot is active we no > > > longer need a temporary for the slot state. > > > - down = type != TOUCH_EVENT_UP; > > > > > > input_mt_slot(tsdata->input, id); > > > - input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, down); > > > > > + if (input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, > > > + type != TOUCH_EVENT_UP)) > > > > Can't we simple do somethink like > > - down = type != TOUCH_EVENT_UP; > > + down = input_mt_report_slot_state(tsdata->input, > > MT_TOOL_FINGER, type != TOUCH_EVENT_UP); > > Why though? The temporary was needed so we did not have to repeat the > expression for "contact down" condition, and now we do not need it. The > whole change was done so that we cab remove the temporary... I see. Thanks for explanation. -- With Best Regards, Andy Shevchenko
