On Mon, 2019-07-01 at 11:45 +0200, Benjamin Tissoires wrote: > Hi Bastien, > > On Wed, Jun 26, 2019 at 4:07 PM Bastien Nocera <hadess@xxxxxxxxxx> > wrote: > > From: Bastien Nocera <bnocera@xxxxxxxxxx> > > > > Add a new hid driver for the Creative SB0540 IR receiver. This > > receiver > > is usually coupled with an RM-1500 or an RM-1800 remote control. > > > > The scrollwheels on the RM-1800 remote are not bound, as they are > > labelled for specific audio controls that don't usually exist on > > most > > systems. They can be remapped using standard Linux keyboard > > remapping tools. > > Much better commit message :) > Thanks! > > I have a few nitpicks however Most of the checkpatch.pl warnings are now fixed. I ignored the one about writing docs for the symbol (I have no idea what it wants, looks like a false positive) and the too long line for the USB device match. <snip> > > + /* force input as some remotes bypass the input > > registration */ > > + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; > > Does this still applies to your remote? Yes, you mentioned it in your original review as well, and it was necessary. v4's been sent. Thanks!
