Re: [PATCH 03/10] dt-bindings: input: touchscreen: stmpe: add resolution support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Freitag, den 14.06.2019, 13:55 -0600 schrieb Rob Herring:
> On Mon, May 27, 2019 at 06:07:29PM +0200, Leif Middelschulte wrote:
> > This documents the support for specifying the screen size in milimeter
> > and its impact on resolution calculation.
> > 
> > Signed-off-by: Leif Middelschulte <
> > leif.middelschulte@xxxxxxxxxxxxx
> > >
> > ---
> >  Documentation/devicetree/bindings/input/touchscreen/stmpe.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > index 04962e2e1ad0..d20dc5a7d8ad 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> > @@ -39,6 +39,10 @@ Optional properties:
> >  				The given window also affects the value range (limits) set
> >  				within the input subsystem which, in turn, affects
> >  				the input resolution calculation on both axes.
> > +- touchscreen-x-mm	: horizontal length in mm of the touchscreen. It affects
> > +				the input resolution calculation on the horizontal axis.
> > +- touchscreen-y-mm	: vertical length in mm of the touchscreen. It affects
> > +				the input resolution calculation on the vertical axis.
> 
> No need to define this again. Just reference the common definition. If 
> you have any additional constraints, then add them.

I assumed it should not be redefined. I merely wanted to document the implication
this value has on the automatically configured resolution within `abs_info`.
Other drivers might not use it in that way, as the general documentation[0] does not
document such a behavior.

[0] https://www.kernel.org/doc/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt

> Rob




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux