On Fri, Jun 14, 2019 at 12:09:57PM -0700, Benson Leung wrote: > Hi Dmitry, > > On Fri, Jun 14, 2019 at 11:55:33AM -0700, Dmitry Torokhov wrote: > > On Fri, Jun 14, 2019 at 11:27:03AM -0700, Enrico Granata wrote: > > > On Thu, Jun 13, 2019 at 11:54 PM Ting Shen <phoenixshen@xxxxxxxxxxxx> wrote: > > > > > > > > http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to > > > > the event_type field, the receiver side should mask out this extra bit when > > > > processing the event. > > > > > > > > Signed-off-by: Ting Shen <phoenixshen@xxxxxxxxxxxx> > > > > > > Reviewed-by: Enrico Granata <egranata@xxxxxxxxxx> > > > > EC_MKBP_EVENT_TYPE_MASK is not in Linus' tree. It would be better to > > merge this path through whatever tree that is bringing in that > > definition. > > > > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Yup, this looks like it's coming in through Lee's MFD tree, a series from > Gwendal to update cros_ec_commands.h. > > 784dd15c930f mfd: cros_ec: Fix event processing API > > That commit is in the immutable branch for v5.3 here: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-v5.3 > > I'd recommend the chrome-platform tree since we'll be pulling in that IB too > for some other refactoring Enric is working on. Yeah, I'm fine with this going through chrome-platform. Thanks. -- Dmitry
