On Wed, Jun 12, 2019 at 4:58 PM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
> Since mxt_video_fops is only used inside an ifdef. It should
> be moved inside the ifdef.
Thanks for the patch! I agree. I think it would be better and clearer
to sink the definition of `mxt_video_fops` down closer to its use,
immediately before the definition of `mxt_video_device`. Then it
would be closer to its use and it would also be within the existing
ifdef.
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -256,6 +256,7 @@ enum v4l_dbg_inputs {
> MXT_V4L_INPUT_MAX,
> };
>
> +#ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
> static const struct v4l2_file_operations mxt_video_fops = {
> .owner = THIS_MODULE,
> .open = v4l2_fh_open,
> @@ -265,6 +266,7 @@ static const struct v4l2_file_operations mxt_video_fops = {
> .mmap = vb2_fop_mmap,
> .poll = vb2_fop_poll,
> };
> +#endif
--
Thanks,
~Nick Desaulniers
