On Mon, Jun 3, 2019 at 11:44 PM Pedro Vanzella <pedro@xxxxxxxxxxxxxxxxx> wrote: > > On 05/28, Benjamin Tissoires wrote: > > On Tue, May 28, 2019 at 6:30 PM Pedro Vanzella <pedro@xxxxxxxxxxxxxxxxx> wrote: > > > > > > Send a low device index when the device is connected via the lightspeed > > > receiver so that the receiver will pass the message along to the device > > > instead of responding. If we don't do that, we end up thinking it's a > > > hidpp10 device and miss out on all new features available to newer devices. > > > > > > This will enable correct detection of the following models: > > > G603, GPro, G305, G613, G900 and G903, and possibly others. > > > > Thanks for the patch. > Thanks for reviewing it :) > > > However, there is already support for this receiver in Linus' tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/hid-logitech-dj.c?id=f5fb57a74e88bd1788f57bf77d587c91d4dc9d57 > > > > With kernel 5.2-rc1, the connected device should already be handled by > > hid-logitech-hidpp :) > Why are the wireless receivers handled by hid-logitech-dj and the wired > mice handled by hid-logitech-hidpp? They are, in the end, all hidpp > devices, and having them all handled by the -hidpp driver with a quirk > class would allow us to check for support for the battery voltage > feature, as it seems to be an either-or scenario here. Yep, and this is exactly what is happening: - the receiver is handled through hid-logitech-dj -> it creates a virtual HID device for the wireless physical device - the actual wireless device is handled through hid-logitech-hidpp (with the virtual HID device created above) This has the advantage of presenting the wireless device in the same way the wired device is. From hid-logitech-hidpp point of view, both are regular HID++ devices. Also, this makes sure each physical device gets its own product ID (we are relying on the wireless product ID), meaning that userspace can differentiate a G900 from a G613 when both are connected to a receiver with the same product ID. Hope that helps. Cheers, Benjamin > > - Pedro > > > > Cheers, > > Benjamin > > > > > > > > Signed-off-by: Pedro Vanzella <pedro@xxxxxxxxxxxxxxxxx> > > > --- > > > drivers/hid/hid-logitech-hidpp.c | 10 +++++++++- > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > > > index 72fc9c0566db..621fce141d9f 100644 > > > --- a/drivers/hid/hid-logitech-hidpp.c > > > +++ b/drivers/hid/hid-logitech-hidpp.c > > > @@ -62,6 +62,7 @@ MODULE_PARM_DESC(disable_tap_to_click, > > > #define HIDPP_QUIRK_CLASS_K400 BIT(2) > > > #define HIDPP_QUIRK_CLASS_G920 BIT(3) > > > #define HIDPP_QUIRK_CLASS_K750 BIT(4) > > > +#define HIDPP_QUIRK_CLASS_LIGHTSPEED BIT(5) > > > > > > /* bits 2..20 are reserved for classes */ > > > /* #define HIDPP_QUIRK_CONNECT_EVENTS BIT(21) disabled */ > > > @@ -236,7 +237,11 @@ static int __hidpp_send_report(struct hid_device *hdev, > > > * set the device_index as the receiver, it will be overwritten by > > > * hid_hw_request if needed > > > */ > > > - hidpp_report->device_index = 0xff; > > > + if (hidpp->quirks & HIDPP_QUIRK_CLASS_LIGHTSPEED) { > > > + hidpp_report->device_index = 0x01; > > > + } else { > > > + hidpp_report->device_index = 0xff; > > > + } > > > > > > if (hidpp->quirks & HIDPP_QUIRK_FORCE_OUTPUT_REPORTS) { > > > ret = hid_hw_output_report(hdev, (u8 *)hidpp_report, fields_count); > > > @@ -3753,6 +3758,9 @@ static const struct hid_device_id hidpp_devices[] = { > > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC06B) }, > > > { /* Logitech G900 Gaming Mouse over USB */ > > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) }, > > > + { /* Logitech Gaming Mice over Lightspeed Receiver */ > > > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC539), > > > + .driver_data = HIDPP_QUIRK_CLASS_LIGHTSPEED }, > > > { /* Logitech G920 Wheel over USB */ > > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL), > > > .driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, > > > -- > > > 2.21.0 > > > > > -- > Pedro Vanzella > pedrovanzella.com > #include <paranoia.h> > Don't Panic
