Re: [PATCH] Input: iqs5xx - Remove redundant dev_set_drvdata call

[Jeff LaBundy <jeff@xxxxxxxxxxx>]

Hi Axel,

On Sun, May 19, 2019 at 12:11:48PM +0800, Axel Lin wrote:
> Calling i2c_set_clientdata() is enough.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
>  drivers/input/touchscreen/iqs5xx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
> index b832fe062645..158707897c2d 100644
> --- a/drivers/input/touchscreen/iqs5xx.c
> +++ b/drivers/input/touchscreen/iqs5xx.c
> @@ -1054,8 +1054,6 @@ static int iqs5xx_probe(struct i2c_client *client,
>  	if (!iqs5xx)
>  		return -ENOMEM;
>  
> -	dev_set_drvdata(&client->dev, iqs5xx);
> -
>  	i2c_set_clientdata(client, iqs5xx);
>  	iqs5xx->client = client;
>  
> -- 
> 2.20.1
> 
> 

Thank you for spotting this.

Acked-by: Jeff LaBundy <jeff@xxxxxxxxxxx>

Thanks,
Jeff L.