Hi, On Thu, May 2, 2019 at 11:37 PM Błażej Szczygieł <spaz16@xxxxx> wrote: > > Since recent high resolution scrolling changes the A4Tech driver must > check for the "REL_WHEEL_HI_RES" usage code. > > Fixes: 2dc702c991e3774af9d7ce410eef410ca9e2357e (HID: input: use the > Resolution Multiplier for high-resolution scrolling) > > Signed-off-by: Błażej Szczygieł <spaz16@xxxxx> Thanks for the patch. I do not doubt this fixes the issues, but I still wonder if we should not export REL_HWHEEL_HI_RES instead of REL_HWHEEL events. Also, I can not figure out how the events are processed by the kernel. Could you attach a hid-recorder dump of the mouse wheels with hid-recorder from https://gitlab.freedesktop.org/libevdev/hid-tools ? This should give me a better view of the mouse, and I could also add it to the regression tests I am running for each commit. Cheers, Benjamin > --- > drivers/hid/hid-a4tech.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-a4tech.c b/drivers/hid/hid-a4tech.c > index 9428ea7cdf8a..fafb9fa558e7 100644 > --- a/drivers/hid/hid-a4tech.c > +++ b/drivers/hid/hid-a4tech.c > @@ -38,7 +38,7 @@ static int a4_input_mapped(struct hid_device *hdev, struct hid_input *hi, > { > struct a4tech_sc *a4 = hid_get_drvdata(hdev); > > - if (usage->type == EV_REL && usage->code == REL_WHEEL) > + if (usage->type == EV_REL && usage->code == REL_WHEEL_HI_RES) > set_bit(REL_HWHEEL, *bit); > > if ((a4->quirks & A4_2WHEEL_MOUSE_HACK_7) && usage->hid == 0x00090007) > @@ -60,7 +60,7 @@ static int a4_event(struct hid_device *hdev, struct hid_field *field, > input = field->hidinput->input; > > if (a4->quirks & A4_2WHEEL_MOUSE_HACK_B8) { > - if (usage->type == EV_REL && usage->code == REL_WHEEL) { > + if (usage->type == EV_REL && usage->code == REL_WHEEL_HI_RES) { > a4->delayed_value = value; > return 1; > } > @@ -77,7 +77,7 @@ static int a4_event(struct hid_device *hdev, struct hid_field *field, > return 1; > } > > - if (usage->code == REL_WHEEL && a4->hw_wheel) { > + if (usage->code == REL_WHEEL_HI_RES && a4->hw_wheel) { > input_event(input, usage->type, REL_HWHEEL, value); > return 1; > } > -- > 2.21.0 >
