Le jeu. 25 avr. 2019 à 09:40, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> a écrit : > > Hi Clément, > > On Wed, Apr 24, 2019 at 5:34 PM Clément VUCHENER > <clement.vuchener@xxxxxxxxx> wrote: > > > > Hi Benjamin, > > > > I tried again to add hi-res wheel support for the G500 with Hans de > > Goede's latest patch series you've just merged in for-5.2/logitech, it > > is much better but there is still some issues. > > > > The first one is the device index, I need to use device index 0 > > instead 0xff. I added a quick and dirty quirk (stealing in the > > QUIRK_CLASS range since the normal quirk range looks full) to change > > the device index assigned in __hidpp_send_report. After that the > > device is correctly initialized and the wheel multiplier is set. > > Hmm, maybe we should restrain a little bit the reserved quirks... > But actually, .driver_data and .quirks are both unsigned long, so you > should be able to use the 64 bits. Only on 64 bits architectures, or is the kernel forcing long integers to be 64 bits everywhere? > > > > > The second issue is that wheel values are not actually scaled > > according to the multiplier. I get 7/8 full scroll event for each > > wheel step. I think it happens because the mouse is split in two > > devices. The first device has the wheel events, and the second device > > has the HID++ reports. The wheel multiplier is only set on the second > > device (where the hi-res mode is enabled) and does not affect the > > wheel events from the first one. > > I would think this have to do with the device not accepting the > command instead. Can you share some raw logs of the events (ideally > with hid-recorder from > https://gitlab.freedesktop.org/libevdev/hid-tools)? I already checked with usbmon and double-checked by querying the register. The flag is set and accepted by the device and it behaves accordingly: it sends about 8 wheel events per step. hid-recorder takes hidraw nodes as parameters, how do I use it to record the initialization by the driver? > > Cheers, > Benjamin > > > > > Le mer. 19 déc. 2018 à 21:35, Benjamin Tissoires > > <benjamin.tissoires@xxxxxxxxxx> a écrit : > > > > > > On Wed, Dec 19, 2018 at 11:57 AM Clément VUCHENER > > > <clement.vuchener@xxxxxxxxx> wrote: > > > > > > > > Le sam. 15 déc. 2018 à 15:45, Clément VUCHENER > > > > <clement.vuchener@xxxxxxxxx> a écrit : > > > > > > > > > > Le ven. 14 déc. 2018 à 19:37, Harry Cutts <hcutts@xxxxxxxxxxxx> a écrit : > > > > > > > > > > > > Hi Clement, > > > > > > > > > > > > On Fri, 14 Dec 2018 at 05:47, Clément VUCHENER > > > > > > <clement.vuchener@xxxxxxxxx> wrote: > > > > > > > Hi, The G500s (and the G500 too, I think) does support the "scrolling > > > > > > > acceleration" bit. If I set it, I get around 8 events for each wheel > > > > > > > "click", this is what this driver expects, right? If I understood > > > > > > > correctly, I should try this patch with the > > > > > > > HIDPP_QUIRK_HI_RES_SCROLL_1P0 quirk set for my mouse. > > > > > > > > > > > > Thanks for the info! Yes, that should work. > > > > > > > > > > Well, it is not that simple. I get "Device not connected" errors for > > > > > both interfaces of the mouse. > > > > > > > > I suspect the device is not responding because the hid device is not > > > > started. When is hid_hw_start supposed to be called? It is called > > > > early for HID_QUIRK_CLASS_G920 but later for other device. So the > > > > device is not started when hidpp_is_connected is called. Is this > > > > because most of the device in this driver are not real HID devices but > > > > DJ devices? How should non-DJ devices be treated? > > > > > > Hi Clement, > > > > > > I have a series I sent last September that allows to support non DJ > > > devices on logitech-hidpp > > > (https://patchwork.kernel.org/project/linux-input/list/?series=16359). > > > > > > In its current form, with the latest upstream kernel, the series will > > > oops during the .event() callback, which is easy enough to fix. > > > However, I am currently trying to make it better as a second or third > > > reading made me realized that there was a bunch of non-sense in it and > > > a proper support would require slightly more work for the non unifying > > > receiver case. > > > > > > I hope I'll be able to send out something by the end of the week. > > > > > > Cheers, > > > Benjamin
