On Monday, April 15, 2019 12:47 PM, Arnd Bergmann wrote: > On Mon, Apr 15, 2019 at 9:39 PM Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: >>> -#define EP93XX_KEYPAD_KDIV (1<<4) /* 1/4 clock or 1/16 clock */ >>> -#define EP93XX_KEYPAD_AUTOREPEAT (1<<5) /* enable key autorepeat */ >>> +#define EP93XX_KEYPAD_AUTOREPEAT (1<<4) /* enable key autorepeat */ >> >> You have re-defined the keypad register bits here. >> >> The KDIV bit changes the clock rate. The AUTOREPEAT bit enables key autorepeat. > > As far as I can tell, they are not register bits, just software flags for communicating between a > board file and the driver, so I assumed I could freely reorganize them. > > Did I miss something? Ugh.. It's been quite a while since I looked at that code... Your correct, these are just flags to the driver. The KeyScanInit register does have some bits that these flags effect but the driver deals with them. I have been buried updating an old PowerPC hardware/software design and haven't looked at the EP93xx lately. My EP9307 board does have the keypad interface. Hopefully I will get some time to check the latest mainline on it sometime soon. Overall these patches look good. So, for the series... Acked-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
