On 11/04/2019 12:35, Jiri Kosina wrote: > On Thu, 11 Apr 2019, Benjamin Tissoires wrote: > >>> So I still am not really happy about this being wired up into generic HID >>> although it's really a USB driver, but we've discussed that already, and I >>> don't see any option that'd work substantially better in this case, >>> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero, >>> thanks! >>> >> >> Hi wish I were CC-ed on these threads. > > Gah, for some reason I was convinced you were. > >> My CI script now fails because hid-u2fzero.ko needs devm_hwrng_register >> and the Kconfig doesn't force pulling the right dependency. >> Also, you probably want to add in .probe() a check for the actual >> transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or >> you can not use the usbhid functions without crashing the kernel. Thanks, that’s very useful. > Benjamin, I love your CI :) > > Andrej, could you please send fixups on top of the applied patch? Sure, will do. -- Cheers, Andrej
