On Tue, 2019-04-09 at 13:29 +0200, Jean Delvare wrote: > The OLPC XO-1.75 and XO-4 are ARM-based laptops, so don't present > this driver on other architectures except for build-testing purposes. > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > Cc: Lubomir Rintel <lkundrak@xxxxx> > Cc: Pavel Machek <pavel@xxxxxx> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > --- > We could even go for a more specific dependency, if anyone knows > which would be appropriate. > > drivers/input/serio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-5.0.orig/drivers/input/serio/Kconfig 2019-03-04 00:21:29.000000000 +0100 > +++ linux-5.0/drivers/input/serio/Kconfig 2019-04-09 13:20:09.822700623 +0200 > @@ -254,6 +254,7 @@ config SERIO_APBPS2 > > config SERIO_OLPC_APSP > tristate "OLPC AP-SP input support" > + depends on ARM || COMPILE_TEST > help > Say Y here if you want support for the keyboard and touchpad included > in the OLPC XO-1.75 and XO-4 laptops. Looks good. Limit this to ARCH_MMP might make even more sense if you care about uncluttering make config. Either way, Reviewed-by: Lubomir Rintel <lkundrak@xxxxx>