Hi Anson, On Fri, Mar 29, 2019 at 07:00:43AM +0000, Anson Huang wrote: > There is no need to enable release interrupt and disable depress > interrupt in event check, as a timer is setup for checking these > events rather than interrupts. But won't using release interrupt allow signalling key release earlier? > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > --- > drivers/input/keyboard/imx_keypad.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c > index 539cb67..7e32c36 100644 > --- a/drivers/input/keyboard/imx_keypad.c > +++ b/drivers/input/keyboard/imx_keypad.c > @@ -276,11 +276,6 @@ static void imx_keypad_check_for_events(struct timer_list *t) > reg_val = readw(keypad->mmio_base + KPSR); > reg_val |= KBD_STAT_KPKR | KBD_STAT_KRSS; > writew(reg_val, keypad->mmio_base + KPSR); > - > - reg_val = readw(keypad->mmio_base + KPSR); > - reg_val |= KBD_STAT_KRIE; > - reg_val &= ~KBD_STAT_KDIE; > - writew(reg_val, keypad->mmio_base + KPSR); > } > } > > -- > 2.7.4 > Thanks. -- Dmitry
