On Thu, Mar 28, 2019 at 11:24 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 28-03-19 23:18, Alex Henrie wrote: > > On Thu, Mar 28, 2019 at 3:20 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> Descriptor fixups obviously need to be done in the kernel, but I > >> believe that key-remapping which can be done through hwdb is best done > >> there as it is a lot easier to update 60-keyboard.hwdb then to change > >> to running a (lot) newer kernel and more importantly we should strive > >> to keep the kernel code as small as possible. > >> > >> Now about this specific keyboards, a quick duckduckgo found me this > >> picture: > >> > >> https://www.bhphotovideo.com/images/images1500x1500/macally_mkeyx_104_key_full_sized_1274821.jpg > > > > The picture you found is of the Macally MKEYX, which I do not have. > > This is the Macally ikey: > > > > https://cultek2.com/products/macally-ikey-wired-usb-keyboard-for-macintosh-or-pc-preowned?variant=12129379156040 > > > > And this is the Macally QKEY: > > > > https://images-na.ssl-images-amazon.com/images/I/61c7zcQJMzL._SL1500_.jpg > > > > The brightness-down and brightness-up keys are Fn+F1 and Fn+F2. The > > keys work as expected on a Mac, so I'm guessing that a long time ago > > Apple decided to repurpose the scancodes for Scroll Lock and Pause, > > leading to the headache we have now. > > Ok. > > > But as you and Benjamin pointed > > out, systemd is a better place to fix this. > > Agreed. > > > So, how about committing the first patch and forgetting about the > > second one? Does the ikey driver need any changes or can it be > > accepted into the kernel as-is? > > That is up to Benjamin. OK for merging the first patch only. I would need a small nitpick then, given that patch 2/2 is dropped. I'll answer in its patch. Cheers, Benjamin
