On 28.03.2019 01:07, Life is hard, and then you die wrote: > Hi Andrzej, > > On Wed, Mar 27, 2019 at 03:13:37PM +0100, Andrzej Hajda wrote: >> +cc: dri-devel >> >> On 27.03.2019 02:48, Ronald Tschalär wrote: >>> commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: >>> sil_sii8620: do not have a dependency of RC_CORE) added a dependency on >>> INPUT. However, this causes problems with other drivers, in particular >>> an input driver that depends on MFD_INTEL_LPSS_PCI (to be added in a >>> future commit): >>> >>> drivers/clk/Kconfig:9:error: recursive dependency detected! >>> drivers/clk/Kconfig:9: symbol COMMON_CLK is selected by MFD_INTEL_LPSS >>> drivers/mfd/Kconfig:566: symbol MFD_INTEL_LPSS is selected by MFD_INTEL_LPSS_PCI >>> drivers/mfd/Kconfig:580: symbol MFD_INTEL_LPSS_PCI is implied by KEYBOARD_APPLESPI >>> drivers/input/keyboard/Kconfig:73: symbol KEYBOARD_APPLESPI depends on INPUT >>> drivers/input/Kconfig:8: symbol INPUT is selected by DRM_SIL_SII8620 >>> drivers/gpu/drm/bridge/Kconfig:83: symbol DRM_SIL_SII8620 depends on DRM_BRIDGE >>> drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_BRIDGE is selected by DRM_PL111 >>> drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on COMMON_CLK >>> >>> According to the docs, select should only be used for non-visible >>> symbols. Furthermore almost all other references to INPUT throughout the >>> kernel config are depends, not selects. Hence this change. >>> >>> CC: Inki Dae <inki.dae@xxxxxxxxxxx> >>> CC: Andrzej Hajda <a.hajda@xxxxxxxxxxx> >>> Signed-off-by: Ronald Tschalär <ronald@xxxxxxxxxxxxx> >> This is drm bridge driver, next time please cc it to dri-devel ML also. > Ok. Though as noted in the cover letter, the patch here is meant as a > placeholder till the real thing being discussed on dri-devel is > finalized. I was trying to avoid cross-posting too much, hence the > separate submission on dri-devel. > >> Anyway this is not the solution we have agreed to. >> >> Why have you abandoned the patch [1]? It needed just some minor >> polishing, as I wrote in response to this mail. >> >> [1]: >> https://lore.kernel.org/lkml/20190124082423.23139-1-ronald@xxxxxxxxxxxxx/T/#mf620df0b1583096a214d8e2e690387078583472f > It seems your mail client doesn't like me :-) I got neither of your > responses. Sorry, I should've checked the archives when I didn't hear > anything. In any case thank you for your review, and I will update > that patch and send out a new version shortly. I see where is the problem: Your mail client (mutt I suppose) sets Mail-Followup-To header to all recipients (To and Cc) without the sender. And my client (thunderbird) after pressing "Reply-All" checks for Mail-Followup-To field, if present it uses only it to set recipients, so in your case it does not response to the original author. I do not know which mail client works incorrectly in this case, but for sure it is not what we want :) I do not know how to solve the issue in thunderbird, maybe mutt is more configurable? Regards Andrzej > > > Cheers, > > Ronald > > >>> --- >>> drivers/gpu/drm/bridge/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >>> index 2fee47b0d50b..eabedc83f25c 100644 >>> --- a/drivers/gpu/drm/bridge/Kconfig >>> +++ b/drivers/gpu/drm/bridge/Kconfig >>> @@ -83,9 +83,9 @@ config DRM_PARADE_PS8622 >>> config DRM_SIL_SII8620 >>> tristate "Silicon Image SII8620 HDMI/MHL bridge" >>> depends on OF >>> + depends on INPUT >>> select DRM_KMS_HELPER >>> imply EXTCON >>> - select INPUT >>> select RC_CORE >>> help >>> Silicon Image SII8620 HDMI/MHL bridge chip driver. >> >
