On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and then you die wrote: > > On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > > On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote: > > > This is the dev_xxx() analog to print_hex_dump(), using dev_printk() > > > instead of straight printk() to match other dev_xxx() logging functions. > > > --- > > > drivers/base/core.c | 43 ++++++++++++++++++++++++++++++++++++++++++ > > > include/linux/device.h | 15 +++++++++++++++ > > > 2 files changed, 58 insertions(+) > > > > No signed-off-by? > > Aargh! Apologies, fixed for the future. > > > Anyway, no, please do not do this. Please do not dump large hex values > > like this to the kernel log, it does not help anyone. > > > > You can do this while debugging, sure, but not for "real" kernel code. > > As used by this driver, it is definitely called for debugging only and > must be explicitly enabled via a module param. But having the ability > for folks to easily generate and print out debugging info has proven > quite valuable. We have dynamic debugging, no need for module parameters at all. This isn't the 1990's anymore :) thanks, greg k-h
