Re: [PATCH] Input: pwm-beeper - make 'amp' as an option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On 3/27/2019 2:49 PM, Dmitry Torokhov wrote:
Hi Jae Hyun,

On Wed, Mar 27, 2019 at 02:00:45PM -0700, Jae Hyun Yoo wrote:
An amplifier regulator property should be an option according to
the binding document but currently it's not so this commit makes
the amplifier regulator property as an option actually for cases
that don't have the actual amplifier H/W.

If regulator is not described in DTS you will get a dummy one (i.e.
devm_regulator_get() will not fail) and everything is good.

This patch is not needed.

Ah, I confused because I got a null beeper->amplifier since I didn't
enable CONFIG_REGULATOR. Even in that case, IS_ERR() doesn't treat
a null as an error so it doesn't matter, and regulator_enable/disable
functions does nothing on the null regulator param so this patch isn't
needed.

If CONFIG_REGULATOR is enabled, it'll get a dummy regulator as you said
so it doesn't need this patch too.

Please ignore this patch.

Thanks,
Jae



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux