On Fri, 2019-03-22 at 00:09 +0100, Hans de Goede wrote: > According to hidpp20_batterylevel_get_battery_info my Logitech K270 > keyboard reports only 2 battery levels. This matches with what I've > seen > after testing with batteries at varying level of fullness, it always > reports either 5% or 30%. > > Windows reports "battery good" for the 30% level. I've captured an > USB > trace of Windows reading the battery and it is getting the same info > as the Linux hidpp code gets. > > Now that Linux handles these devices as hidpp devices, it reports the > battery as being low as it treats anything under 31% as low, this > leads > to the user constantly getting a "Keyboard battery is low" warning > from > GNOME3, which is very annoying. > > This commit fixes this by changing the low threshold to anything > under > 30%, which I assume is what Windows does. upower doesn't use the battery percentage if there's a "Capacity" set. If something else in the stack does, then there's a bug in that component and the problem needs to be fixed there. See: https://gitlab.freedesktop.org/upower/upower/blob/master/dbus/org.freedesktop.UPower.Device.xml#L514 https://gitlab.freedesktop.org/upower/upower/blob/master/dbus/org.freedesktop.UPower.Device.xml#L621
