On Fri, 2019-03-22 at 00:09 +0100, Hans de Goede wrote:
> According to hidpp20_batterylevel_get_battery_info my Logitech K270
> keyboard reports only 2 battery levels. This matches with what I've
> seen
> after testing with batteries at varying level of fullness, it always
> reports either 5% or 30%.
>
> Windows reports "battery good" for the 30% level. I've captured an
> USB
> trace of Windows reading the battery and it is getting the same info
> as the Linux hidpp code gets.
>
> Now that Linux handles these devices as hidpp devices, it reports the
> battery as being low as it treats anything under 31% as low, this
> leads
> to the user constantly getting a "Keyboard battery is low" warning
> from
> GNOME3, which is very annoying.
>
> This commit fixes this by changing the low threshold to anything
> under
> 30%, which I assume is what Windows does.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 421a190583eb..d811c3bab495 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -1054,7 +1054,7 @@ static int hidpp_map_battery_level(int
> capacity)
> {
> if (capacity < 11)
> return POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL;
> - else if (capacity < 31)
> + else if (capacity < 30)
> return POWER_SUPPLY_CAPACITY_LEVEL_LOW;
> else if (capacity < 81)
> return POWER_SUPPLY_CAPACITY_LEVEL_NORMAL;
Shouldn't the other values be changed as well to keep somewhat of a
standard? People reading this code without prior knowledge of the file
history will just scratch their head when seeing this.
Filipe Laíns
3DCE 51D6 0930 EBA4 7858 BA41 46F6 33CB B0EB 4BF2
Attachment:
signature.asc
Description: This is a digitally signed message part
