Re: [PATCH] Input: synaptics-rmi4 - write config register values to the right offset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2019-03-08 at 16:08 +0100, Lucas Stach wrote:
> Currently any changed config register values don't take effect, as the
> function to write them back is called with the wrong register offset.
> 
> Fixes: ff8f83708b3e (Input: synaptics-rmi4 - add support for 2D
>                      sensors and F11)
> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> ---
>  drivers/input/rmi4/rmi_f11.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index df64d6aed4f7..75b7bef7512e 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -1229,8 +1229,9 @@ static int rmi_f11_initialize(struct rmi_function *fn)
>  		}
>  	}
>  
> +

Spurious whitespace change?

>  	rc = f11_write_control_regs(fn, &f11->sens_query,
> -			   &f11->dev_controls, fn->fd.query_base_addr);
> +			   &f11->dev_controls, fn->fd.control_base_addr);
>  	if (rc)
>  		dev_warn(&fn->dev, "Failed to write control registers\n");
>  

regards
Philipp



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux