On Mon, Feb 11, 2019 at 09:07:43PM +0800, 廖崇榮 wrote: > > > -----Original Message----- > From: 廖崇榮 [mailto:kt.liao@xxxxxxxxxx] > Sent: Monday, February 11, 2019 10:43 AM > To: 'Dmitry Torokhov'; 'Patrick Dreyer' > Cc: 'linux-input@xxxxxxxxxxxxxxx'; 'pbreuch@xxxxxxxxxxx'; 'mt-ml@xxxxxx' > Subject: RE: [PATCH] elan_i2c_core: Add ACPI ID for ASUS Aspire F5-573G > > Hi Dmitry, > > -----Original Message----- > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > Sent: Wednesday, February 06, 2019 8:43 AM > To: Patrick Dreyer; 廖崇榮 > Cc: linux-input@xxxxxxxxxxxxxxx; pbreuch@xxxxxxxxxxx; mt-ml@xxxxxx > Subject: Re: [PATCH] elan_i2c_core: Add ACPI ID for ASUS Aspire F5-573G > > Hi Patrick, > > On Sun, Dec 23, 2018 at 7:37 AM Patrick Dreyer <Patrick@xxxxxxxxxxx> wrote: > > > > Problem: > > Multi touchpad is not recognized on ASUS Aspire F5-573G. > > > > Description: > > Add ELAN0501 to the ACPI table to support Elan touchpad found in ASUS > > Aspire F5-573G > > > > Patch: > > > > --- input/drivers/input/mouse/elan_i2c_core.c.orig 2018-12-23 16:20:37.737166868 +0100 > > +++ input/drivers/input/mouse/elan_i2c_core.c 2018-12-23 16:20:00.889663448 +0100 > > @@ -1336,6 +1336,7 @@ MODULE_DEVICE_TABLE(i2c, elan_id); static const > > struct acpi_device_id elan_acpi_id[] = { > > { "ELAN0000", 0 }, > > { "ELAN0100", 0 }, > > + { "ELAN0501", 0 }, > > { "ELAN0600", 0 }, > > { "ELAN0602", 0 }, > > { "ELAN0605", 0 }, > > > > Signed-off-by: Patrick Dreyer <Patrick.Dreyer@xxxxxxxxx> > > Apparently this breaks Acer Aspire V-371 > (https://bugzilla.kernel.org/show_bug.cgi?id=202503) and some others. > > Patrick, have you tried running i2c-hid/hid-multitouch on your device? > > KT, do you know what driver should be used with ELAN0501 devices? > > Our PM confirm that Acer Aspire F5-573G is MS Precision touchpad which should use hid multitouch driver. > > I just get a Acer notebook and confirm that Acer series use ELAN0501 as touchpad's ACPI ID. > ELAN0501 should not be added in elan_i2c. > I can't guarantee that if any brand/ODM use ELAN0501 for elan_i2c touchpad but very low probability. Thank you KT, will will queue the revert. Thanks. -- Dmitry
