On Sat, Feb 9, 2019 at 12:21 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > Now that LEDs core allows "blocking" flavor of "set brightness" method we > can use it and get rid of private work items. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Looking good ! Reviewed-by: Sven Van Asbroeck <TheSven73@xxxxxxxxx> Good job to get rid of that led_lock mutex. It didn't serve any purpose but more importantly, it could introduce a sleep in brightness_set, which cannot sleep...