Hi Dan, On Tue, Feb 05, 2019 at 01:21:10PM +0300, Dan Carpenter wrote: > Hi Ronald, > > Thank you for the patch! Perhaps something to improve: > > url: https://github.com/0day-ci/linux/commits/Ronald-Tschal-r/drm-bridge-sil_sii8620-depend-on-INPUT-instead-of-selecting-it/20190205-003319 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next > > smatch warnings: > drivers/input/keyboard/applespi.c:1551 applespi_get_saved_bl_level() warn: returning -1 instead of -ENOMEM is sloppy [snip] > cfa9f3705 Ronald Tschalär 2019-02-04 1549 efivar_entry = kmalloc(sizeof(*efivar_entry), GFP_KERNEL); > cfa9f3705 Ronald Tschalär 2019-02-04 1550 if (!efivar_entry) > cfa9f3705 Ronald Tschalär 2019-02-04 @1551 return -1; Agreed, that is sloppy. Fixed in for next version. Thanks! Cheers, Ronald
