On Tue, 22 Jan 2019, hongyan.song@xxxxxxxxx wrote: > From: Song Hongyan <hongyan.song@xxxxxxxxx> > > Host driver should handle interrupt mask register earlier than wake up > ish FW else there will be conditions when FW interrupt comes, host > PIMR register still not set ready, so move the interrupt mask setting > before ish_wakeup. > > Clear PISR busy_clear bit in ish_irq_handler. If not clear, there will > be conditions host driver received a busy_clear interrupt (before the > busy_clear mask bit is ready), it will return IRQ_NONE after > check_generated_interrupt, the interrupt will never be cleared, > causing the DEVICE not sending following IRQ. > > Since PISR clear should not be called for the CHV device we do this > change. After the change, both ISH2HOST interrupt and busy_clear > interrupt will be considered as interrupt from ISH, busy_clear > interrupt will return IRQ_HANDLED from IPC_IS_BUSY check. > > Signed-off-by: Song Hongyan <hongyan.song@xxxxxxxxx> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> Applied to for-5.1/ish. Thanks, -- Jiri Kosina SUSE Labs
