On Tue, Jan 22, 2019 at 11:50:50PM -0800, VDR User wrote: > > > > > > KEY_DISPLAY_FORMAT doesn't open any menus and is used to cycle through > > > how video is displayed on-screen to the user; full, zoomed, > > > letterboxed, stretched, etc. KEY_CONTEXT_MENU would be for something > > > like bringing up a playback menu where you'd set things like > > > upscaling, deinterlacing, audio mixdown/mixup, etc. > > > > KEY_ASPECT_RATIO (formerly KEY_SCREEN). > > Physical displays have a single set aspect ratio (W/H). Images have > their own aspect ratios. When the AR of the video to be display and > the display itself are mismatched, you have to do something > (letterbox, pillarbox, windowbox) to the video to maintain the correct > video aspect ratio. You can't change the displays AR, and you aren't > changing the videos AR so using KEY_ASPECT_RATIO makes no sense. AR > isn't being touched/altered/manipulated, but how the video is being > displayed is. Stretching and filling to match the display AR alters > the video AR so there is makes sense, but then zooming may not. So, > since "aspect ratio" kind of makes sense in a couple cases, and makes > no sense in the rest, the more suitable KEY_DISPLAY_FORMAT is my > suggestion. No, we will not be renaming this key. We try to have parity with the HUT, which has the following to say: "Aspect OSC - Selects the next available supported aspect ratio option on a device which outputs or displays video. For example, common aspect ratio options are 4:3 (standard definition), 16:9 (often used to stretch a standard definition source signal to a 16:9 video screen), letter-box and anamorphic widescreen.The order in which the aspect ratios are selected is implementation specific." Thanks. -- Dmitry
