On Mon, Jan 14, 2019 at 7:40 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > On Sat, Jan 12, 2019 at 04:04:36PM -0600, Kim Phillips wrote: > > On 1/11/19 7:40 PM, Dmitry Torokhov wrote: > > > Hi Kim, > > > > Hi Dmitry, > > > > > On Fri, Jan 11, 2019 at 02:54:30PM -0600, Kim Phillips wrote: > > >> This patch is the result of seeing this message: > > >> > > >> psmouse serio1: synaptics: Your touchpad (PNP: DLL087c PNP0f13) says it can support a different bus. If i2c-hid and hid-rmi are not used, you might want to try setting psmouse.synaptics_intertouch to 1 and report this to linux-input@xxxxxxxxxxxxxxx. > > >> > > >> If I set psmouse.synaptics_intertouch=1, or add the PNP ID to > > >> smbus_pnp_ids, the touchpad continues to work, and the above message > > >> goes away, but we now get: > > >> > > >> psmouse serio1: synaptics: Trying to set up SMBus access > > >> psmouse serio1: synaptics: SMbus companion is not ready yet > > >> > > >> With this patch applied, i.e., the PNP IDs are added to the forcepad > > >> array, the touchpad continues to work and all of the above messages > > >> disappear. > > > > > > Are you sure the touchpad in XPSes is a forcepad (i.e. it does not have > > > physical button underneath it)? As far as I know there were only couple > > > of HP laptops with forcepads and when switching to RMI mode forcepads > > > need F21 handler that we do not currently have in the kernel. > > > > I see, no, I'm not sure, but assuming you're right, the IDs > > should be added to the smbus array instead, after fixing > > the SMbus "companion not ready" problem? Pointers for that and > > the below interrupts when touchpad idle after resume, welcome. > > > > Also, the link to get the RMI4 spec in > > Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt > > is broken. Any pointers for that also appreciated. > > OK, sorting it all out some more: > > - because we do not have support for F21 necessary for forcepads adding > APIC ID to forcepad list actuallty disables SMbus companion mode, that > is why you no longer see "companion not ready" messages vs. setting > psmouse.synaptics_intertouch=1 module parameter. Yep > > - this does not really matter as your touchpad ends up being driven by > i2c-hid and hid-multitouch drivers, and that is how we wait it to > work, as we do not want to deviate from behavior on Windows since OEM > tested it (the device and firmware) in tha configuration. Yep too. The I2C-hid touchpads from Synaptics do not have the SMBus wired at all, so we can't enable SMBus for them. Also, the fact that the device gets loaded over i2c-hid means that we can't know that it is the case from the psmouse/synaptics point of view. > > - we need to figure out issue with interrupts on resume, maybe Benjamin > have seen it? First time I see it. I just tried on a XPS 9360 and kernel v4.18 (fedora) and nothing was a problem. I then tried on a XPS 9575 with v4.19, and here, the wacom I2C node is also keeping firing the interrupts, but not the touchpad. However, here, the interrupts are not stopping when I touch the touchscreen or if I approach a pen. Kim, rmmod-ing i2c-hid and modprobing back it with the parameter debug=1 doesn't show any events processed when the interrupts are firing. Do you see the same? Cheers, Benjamin
