On Mon, 2019-01-07 at 16:56 +0100, Bastien Nocera wrote: > Given that we do have access to the datasheet, it would also be > useful > for the patch to mention where in the datasheet it says that the > reset > line can be left pulled-up, or mention on which shipping device this > setup is already used (and if so, what the DTS or ACPI snippet that > declares those is). Or alternatively, and as Andreas pointed out in another thread, find the code in the vendor driver that does support this setup: https://github.com/goodix/gt9xx_driver_android https://github.com/goodix/goodix_gt9xx_public If it doesn't work with the vendor code, then we might not want to make it work with our driver either. Cheers