On Wed, Dec 5, 2018 at 8:56 AM Chris Chiu <chiu@xxxxxxxxxxxx> wrote: > > On Fri, Nov 30, 2018 at 7:18 PM Benjamin Tissoires > <benjamin.tissoires@xxxxxxxxxx> wrote: > > > > On Fri, Nov 30, 2018 at 7:46 AM Chris Chiu <chiu@xxxxxxxxxxxx> wrote: > > > > > > The ASUS laptops start to support the airplane mode radio management > > > to replace the original machanism of airplane mode toggle hotkey. > > > On the ASUS P5440FF, it presents as a HID device connecting via > > > I2C, name i2c-AMPD0001. When pressing hotkey, the Embedded Controller > > > send hid report up via I2C and switch the airplane mode indicator > > > LED based on the status. > > > > > > However, it's not working because it fails to be identified as a > > > hidinput device. It fails in hidinput_connect() due to the macro > > > IS_INPUT_APPLICATION doesn't identify HID_GD_WIRELESS_RADIO_CTLS > > > as a legit application code. > > > > > > It's easy to add the HID I2C vendor and product id to the quirk > > > list and apply HID_QUIRK_HIDINPUT_FORCE to make it work. But it > > > can be more generic to support such kind of application on PC. > > > > Sounds good, but while you are at it, can you please: > > - fix the kbuild warning > > - rewrite the whole line to use macros, > > - make the macro prettier by inserting new lines were required > > - and define the missing macro: > > 0x000d0006 -> HID_DG_WHITEBOARD > > > > Maybe we should keep the ranges definitions with raw values and put a > > comment on the side with the names. > > > > Cheers, > > Benjamin > > > > Hi Bejamin, > Thanks for your comment, I've submitted other patches which may > fulfill your suggestion. > https://lore.kernel.org/patchwork/patch/1020373/ > https://lore.kernel.org/patchwork/patch/1020374/ > > Please help me review and correct me if there's any modification > required. Thanks & Regards. > > Chris > Gentle ping. Any comment for the new patch? Thanks and Regards. Chris > > > > > > Signed-off-by: Chris Chiu <chiu@xxxxxxxxxxxx> > > > --- > > > include/linux/hid.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/linux/hid.h b/include/linux/hid.h > > > index d44a78362942..f4805f605fed 100644 > > > --- a/include/linux/hid.h > > > +++ b/include/linux/hid.h > > > @@ -836,7 +836,7 @@ static inline bool hid_is_using_ll_driver(struct hid_device *hdev, > > > > > > /* Applications from HID Usage Tables 4/8/99 Version 1.1 */ > > > /* We ignore a few input applications that are not widely used */ > > > -#define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006))) > > > +#define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || || (a == 0x0001000c) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006))) > > > > > > /* HID core API */ > > > > > > -- > > > 2.11.0 > > >
