Re: [PATCH] Input: rotary-encoder: Don't log EPROBE_DEFER to kernel log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 04, 2018 at 04:38:12PM -0800, Dmitry Torokhov wrote:
> Hi Uwe,
> 
> On Tue, Dec 04, 2018 at 09:10:32PM +0100, Uwe Kleine-König wrote:
> > Hello Dmitry,
> > 
> > On Sun, Oct 07, 2018 at 10:37:26PM +0200, Uwe Kleine-König wrote:
> > > When a driver fails to bind because a resource it still missing it's not
> > > helpful to report this as (usually) probing is repeated later.
> > > 
> > > Signed-off-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> > 
> > did this patch fell throug the cracks? I didn't get any feedback for it.
> 
> Sorry, must have missed it. Do not have that strong preference either
> way. I guess we can't really do anything to avoid deferral, so there is
> no point in telling the reason for deferring.

I think there is a strong reason to not emit a warning on deferral:
There is no success-message when the device is probed (which is a good
choice IMHO) and with the warning emitted the only sign that the device
is there is this warning telling that it was unable to get its hands on
the gpios. This is irritating for users and testers because when the
message is noticed the content is (usually) already wrong.

> I'll apply this.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux