On Fri, Nov 30, 2018 at 6:03 AM Peter Hutterer <peter.hutterer@xxxxxxxxx> wrote: > Given the bits I've seen from openrazer, > there is quite a struggle to get things to work on all devices correctly, so > there's a high chance that a) this won't work on the devices and b) that > you're locking yourself into an API that cannot be supported on next year's > device. The ABI (not API, but maybe I'm being picky) used here is that of the LED class, extended with one sysfs file that selects a keyboard effect from an enumerated list of effects. Anything more esoteric than that is not part of the patch and maybe should be handled by userspace rather than the kernel. Let me iterate this point: both/and not either/or. Yours, Linus Walleij