On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote:
> Hi Lee,
> I have just one question regarding i2c_device_id.
Don't forget to trim your responses.
Lots of unrequired quotes here.
[...]
> >> +static const struct i2c_device_id stpmic1_id[] = {
> >> + { "stpmic1"},
> >> + {}
> >> +};
> > I don't think this is required any more.
> should I replace with the following ?
>
> static const struct of_device_id stpmic1_of_match[] = {
> { .compatible = "st,stpmic1", },
> {},
> };
> MODULE_DEVICE_TABLE(of, stpmic1_of_match);
I think it should have had that already. So yes, please.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
