On Wed, Nov 21, 2018 at 11:52 AM Daniel M. Lambea <dmlambea@xxxxxxxxx> wrote:
>
>
>
> El mié., 21 nov. 2018 10:49, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> escribió:
>>
>> On Wed, Nov 21, 2018 at 11:40 AM Daniel M. Lambea <dmlambea@xxxxxxxxx> wrote:
>> >
>> >
>> >
>> > El mié., 21 nov. 2018 10:17, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> escribió:
>> >>
>> >> Hi Daniel,
>> >>
>> >> On Sun, Nov 18, 2018 at 3:43 PM Daniel M. Lambea <dmlambea@xxxxxxxxx> wrote:
>> >> >
>> >> > Add USB ID 060b:700a to the list of valid USB IDS for the
>> >> > cougar hid driver.
>> >>
>> >> Just a question so I know where to apply this.
>> >> Does the keyboard works fine currently and is just missing a few extra
>> >> features or the switch to hid-cougar is definitively required?
>> >
>> >
>> > The driver is working fine but since it is only targeting the 500K model, other models are not being supported. It seems that model 700K is compatible with current hid-cougar, so adding its USB ID to the driver's list of supported devices will make it work.
>>
>> My question is more about the current status of the keyboard with
>> hid-generic in 4.19.
>> I get that the keyboard works fine with hid-cougar, it's just to know
>> if I need to send this to Linus ASAP and CC stable@ or if this can
>> wait 4.21.
>
>
> Oh, I see, sorry. It is not urgent, it just adds support for another model. I think it can wait for 4.21
Heh. Thanks for the quick answers. I'll apply it ASAP so it gets out
of our patch queues.
Cheers,
Benjamin
>
> Cheers!
>
>> Cheers,
>> Benjamin
>>
>> >
>> >> Cheers,
>> >> Benjamin
>> >>
>> >> >
>> >> > Signed-off-by: Daniel M. Lambea <dmlambea@xxxxxxxxx>
>> >> > ---
>> >> > drivers/hid/hid-cougar.c | 2 ++
>> >> > drivers/hid/hid-ids.h | 1 +
>> >> > 2 files changed, 3 insertions(+)
>> >> >
>> >> > diff --git a/drivers/hid/hid-cougar.c b/drivers/hid/hid-cougar.c
>> >> > index 3f0916b64c60..e0bb7b34f3a4 100644
>> >> > --- a/drivers/hid/hid-cougar.c
>> >> > +++ b/drivers/hid/hid-cougar.c
>> >> > @@ -326,6 +326,8 @@ module_param_cb(g6_is_space, &cougar_g6_is_space_ops, &g6_is_space, 0644);
>> >> > static struct hid_device_id cougar_id_table[] = {
>> >> > { HID_USB_DEVICE(USB_VENDOR_ID_SOLID_YEAR,
>> >> > USB_DEVICE_ID_COUGAR_500K_GAMING_KEYBOARD) },
>> >> > + { HID_USB_DEVICE(USB_VENDOR_ID_SOLID_YEAR,
>> >> > + USB_DEVICE_ID_COUGAR_700K_GAMING_KEYBOARD) },
>> >> > {}
>> >> > };
>> >> > MODULE_DEVICE_TABLE(hid, cougar_id_table);
>> >> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> >> > index f63489c882bb..69ccda9280d9 100644
>> >> > --- a/drivers/hid/hid-ids.h
>> >> > +++ b/drivers/hid/hid-ids.h
>> >> > @@ -1010,6 +1010,7 @@
>> >> >
>> >> > #define USB_VENDOR_ID_SOLID_YEAR 0x060b
>> >> > #define USB_DEVICE_ID_COUGAR_500K_GAMING_KEYBOARD 0x500a
>> >> > +#define USB_DEVICE_ID_COUGAR_700K_GAMING_KEYBOARD 0x700a
>> >> >
>> >> > #define USB_VENDOR_ID_SOUNDGRAPH 0x15c2
>> >> > #define USB_DEVICE_ID_SOUNDGRAPH_IMON_FIRST 0x0034
>> >> > --
>> >> > 2.17.1
>> >> >
