On Wed, 3 Oct 2018, Vladis Dronov wrote: > This patchset is fixing some aspects of the ring buffer implementation in > drivers/hid/hid-debug.c. This implementation has certain problem points: > > - it may stuck in an infinite loop > - it may return corrupted data > - a reader and a writer are not protected by spinlocks, which can lead to > the corrupted data > > The suggested patchset is a new ring buffer implementation which overwrites > the oldest data in case of an overflow. One can verify the suggested ring > buffer implementation by fuzzing it with modified kernel and fuzzer-reader > at: https://gist.github.com/nefigtut/33d56e3870b67493cc867344aed2a062 Vladis, thanks for cleaning it up. I actually like your rewrite quite a lot. Quick question -- how well was it tested in which scenarios? -- Jiri Kosina SUSE Labs
