Hi Dmitry,
On Fri, Sep 21, 2018 at 04:31:19PM -0700, Dmitry Torokhov wrote:
> > > + if (!parent_pset)
> > > + return ERR_PTR(-EINVAL);
> > > +
> > > + p = pset_create_set(properties);
> > > + if (IS_ERR(p))
> > > + return ERR_CAST(p);
> > > +
> > > + p->dev = dev;
> >
> > That looks wrong.
> >
> > I'm guessing the assumption here is that the child nodes will never be
> > assigned to their own devices, but you can't do that. It will limit
> > the use of the child nodes to a very small number of cases, possibly
> > only to gpios.
>
> If I need to assign a node to a device I'll use device_add_properties()
> API. device_add_child_properties() is for nodes living "below" the
> device.
device_add_properties() is not available to us before we have the
actual struct device meant for the properties. If the child device is
populated outside of the "boardfiles" then we have to be able to link
it to the child node afterwards.
But I took a closer look at the code and realized that you are not
using that p->dev with the child nodes for anything, so I may be wrong
about this. You are not actually linking the child nodes to that
device here.
> All nodes (the primary/secondary and children) would point to the owning
> device, just for convenience.
Since you don't use that for anything, then drop that line. It's only
confusing.
And besides, since we will have separate child devices for those child
nodes, there is a small change that somebody needs to call
device_remove_properties(child_dev). At least then that operation
becomes safe, as it's a nop with the child pset nodes.
> > I think that has to be fixed. It should not be a big deal. Just expect
> > the child nodes to be removed separately, and add ref counting to the
> > struct property_set handling.
>
> Why do we need to remove them separately and what do we need refcounting
> for?
If you could remove the nodes independently, then obviously the parent
can not be removed before the children. The ref count would be there
to prevent that.
Though my original comment is not valid, I still think that the child
nodes should be created and destroyed separately. Actually, I don't
think we should be talking about child nodes in the API at all. Check
below..
> > > + p->parent = parent_pset;
> > > + list_add_tail(&p->child_node, &parent_pset->children);
> > > +
> > > + return &p->fwnode;
> > > +}
> > > +EXPORT_SYMBOL_GPL(device_add_child_properties);
> >
> > The child nodes will change the purpose of the build-in property
> > support. Originally the goal was just to support adding of build-in
> > device properties to real firmware nodes, but things have changed
> > quite a bit from that. These child nodes are purely tied to the
> > build-in device property support, so we should be talking about adding
> > pset type child nodes to pset type parent nodes in the API:
> > fwnode_pset_add_child_node(), or something like that.
>
> OK, I can change device_add_child_properties() to
> fwnode_pset_add_child_node() if Rafael would prefer this name.
So not even that. We should have API like this:
struct fwnode_handle *
fwnode_pset_create(struct fwnode_handle *parent, const char *name,
const struct property_entry *props);
void fwnode_pset_destroy(struct fwnode_handle *fwnode);
int device_add_properties(struct device *dev,
const struct fwnode_handle *pset_node);
void device_remove_properties(struct device *dev);
So basically we separate creation of the nodes from linking them to the
devices completely. That would give this API much better structure. It
would scale better, for example, it would then be possible to add
child nodes from different locations if needed.
Thanks,
--
heikki
