Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Drake/i8042-enable-keyboard-wakeups-by-default-when-s2idle-is-used/20180911-173115 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: x86_64-randconfig-f0-09171244 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/input/serio/i8042.c: In function 'i8042_register_ports': >> drivers/input/serio/i8042.c:1416:7: error: 'mem_sleep_current' undeclared (first use in this function) if (mem_sleep_current == PM_SUSPEND_TO_IDLE ^~~~~~~~~~~~~~~~~ drivers/input/serio/i8042.c:1416:7: note: each undeclared identifier is reported only once for each function it appears in vim +/mem_sleep_current +1416 drivers/input/serio/i8042.c 1390 1391 static void __init i8042_register_ports(void) 1392 { 1393 int i; 1394 1395 for (i = 0; i < I8042_NUM_PORTS; i++) { 1396 struct serio *serio = i8042_ports[i].serio; 1397 1398 if (!serio) 1399 continue; 1400 1401 printk(KERN_INFO "serio: %s at %#lx,%#lx irq %d\n", 1402 serio->name, 1403 (unsigned long) I8042_DATA_REG, 1404 (unsigned long) I8042_COMMAND_REG, 1405 i8042_ports[i].irq); 1406 serio_register_port(serio); 1407 device_set_wakeup_capable(&serio->dev, true); 1408 1409 /* 1410 * On platforms using suspend-to-idle by default, make the 1411 * keyboard wake up the system from sleep by enabling keyboard 1412 * wakeups by default. That is consistent with keyboard 1413 * wakeup behavior on many platforms using suspend-to-RAM 1414 * (ACPI S3) by default. 1415 */ > 1416 if (mem_sleep_current == PM_SUSPEND_TO_IDLE 1417 && i == I8042_KBD_PORT_NO) 1418 device_set_wakeup_enable(&serio->dev, true); 1419 } 1420 } 1421 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
