On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote:
> The CapsLock key on Atari keyboards is not a toggle, it does send the
> normal make and break scancodes.
>
> Drop the CapsLock toggle handling code, which did cause the CapsLock
> key to merely act as a Shift key.
>
> Tested-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
> Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
Andreas, I have no idea how Atari keyboards work, can you add your
signed-off-by (or NAK) to this one as well please?
>
> ---
> drivers/input/keyboard/atakbd.c | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/input/keyboard/atakbd.c b/drivers/input/keyboard/atakbd.c
> index e989574..6caee80 100644
> --- a/drivers/input/keyboard/atakbd.c
> +++ b/drivers/input/keyboard/atakbd.c
> @@ -185,14 +185,8 @@ static void atakbd_interrupt(unsigned char scancode, char down)
>
> scancode = atakbd_keycode[scancode];
>
> - if (scancode == KEY_CAPSLOCK) { /* CapsLock is a toggle switch key on Amiga */
> - input_report_key(atakbd_dev, scancode, 1);
> - input_report_key(atakbd_dev, scancode, 0);
> - input_sync(atakbd_dev);
> - } else {
> - input_report_key(atakbd_dev, scancode, down);
> - input_sync(atakbd_dev);
> - }
> + input_report_key(atakbd_dev, scancode, down);
> + input_sync(atakbd_dev);
> } else /* scancodes >= 0xf3 are mouse data, most likely */
> printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode);
>
> --
> 1.7.0.4
>
--
Dmitry
