Re: [PATCH v3] i8042: enable keyboard wakeups by default when s2idle is used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 11, 2018 at 3:53 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On a second thought, it may be better to use mem_sleep_default here.

It looks like mem_sleep_default will ordinarily be PM_SUSPEND_MAX on a
s2idle system.

The acpi/sleep.c code that deals with the lps0 device just does this:

        /*
         * Use suspend-to-idle by default if the default
         * suspend mode was not set from the command line.
         */
        if (mem_sleep_default > PM_SUSPEND_MEM)
            mem_sleep_current = PM_SUSPEND_TO_IDLE;

> And you need to provide an empty stub for it for !CONFIG_SUSPEND.
>
> It may be even better to have a wrapper function around it, something
> like pm_default_s2idle() maybe?

A wrapper sounds good. Would you prefer that to be introduced in a
separate patch, or should I roll it into this patch?

Daniel



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux