Re: [PATCH] hid: increase maximum global item tag report size to 256

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 1 Aug 2018, Song Hongyan wrote:

> From: "Song, Hongyan" <hongyan.song@xxxxxxxxx>
> 
> The maximum globale report size has changed from 32->...->96->128 in
> the past years.
> With the development usage of HID, the report_size max value 128 cannot
> satisfy all requirements. There is a need which report size is 192,
> while max size 128 blocked it as illegal length, so increase the
> report size to satisfy it and more demands in the future.

Could you please be more specific in the changelogs which (groups of) 
devices require this?

Thanks.

> 
> Signed-off-by: Song Hongyan <hongyan.song@xxxxxxxxx>
> ---
>  drivers/hid/hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 3942ee6..d9c1d12 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -396,7 +396,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item)
>  
>  	case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
>  		parser->global.report_size = item_udata(item);
> -		if (parser->global.report_size > 128) {
> +		if (parser->global.report_size > 256) {
>  			hid_err(parser->device, "invalid report_size %d\n",
>  					parser->global.report_size);
>  			return -1;

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux