On Tue, 2018-07-17 at 14:22 +0200, Robert Munteanu wrote: > On Tue, 2018-07-17 at 00:32 -0400, John S Gruber wrote: > > On Mon, Jul 16, 2018 at 4:51 AM Robert Munteanu <rombert@xxxxxxxxxx > > > > > wrote: > > > > > > Hi John, > > > > > > On Sat, 2018-07-14 at 18:06 -0700, John S Gruber wrote: > > > > The Redragon keyboard uses the second device being presented, > > > > but > > > > other > > > > devices with the same vendor_id/device_id pair (0x0c45:760b) > > > > use > > > > the > > > > first. > > > > Don't cause its deletion. Problem introduced in commit > > > > 85455dd906d5 > > > > ("HID: redragon: Fix modifier keys for Redragon Asura > > > > Keyboard") > > > > > > > > > This should already be fixed by > > > dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e [1], can you please > > > confirm? > > > > I applied it to the tip of linux-input repo (Jiri's) and to 4.18- > > rc5 > > in Linus' repo. > > > > In both cases the keyboard went from not working at all to working > > fine. > > > > > > > > If that is the case, we should probably include that commit for > > > 4.18 as > > > well. > > > > That would work for me. > > Jiri, do you agree? If you do, should I resubmit the patch or is this > email thread enough? Ping? Should I resubmit the patch with the updated findings from John? Robert -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html