On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. > > +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw) > > > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > > + .dattr = __ATTR(_field, S_IRUGO, \ > > > > Signed-off-by: Harshit Jain <harshitjain6751@xxxxxxxxx> > > This name doesn't match up with the From: line above :( > > Please fix up and try again. dtor@dtor-ws:~/kernel/linux-next$ git grep S_IRU | wc -l 7605 We either need to run a tree-wide script or leave this alone. FWIW I am perfectly fine with either octals or symbolic names so I do not see benefit of doing conversion for code that is not known to be broken. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
