Hello Huang, hello Benjamin, the code of hid-betopff.c served as my guide when writing a driver for a different gamepad device. Thanks! Benjamin commented a few issues in my new driver that also applied to your driver, so allow me to fix those here, too. This is v2 of my previous patch. It contains a minor reshuffling of the code so that _init() can be folded back into _probe(), which will fix the error handling. Afterwards, devm_kzalloc() is used to make kfree() obsolete. Benjamin, I do not own the gamepad for this driver. My patched version compiles cleanly, but please have a look over it. Thank you, Hanno -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html