The Acer branded keyboard that came with my Acer ATC-605-UB11 computer system fails to see any keystrokes due to: 85455dd906d5 ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard.") That commit is in 4.18.0-rc4. The vendor_id device_id combination 0c45:760b is shared by those keyboards, as well as many others. See https://linux-hardware.org/index.php?id=usb:0c45-760b. While the Redragon keyboard uses the second device presented and not the first, the Acer, and perhaps many others, use that first device (with dev->maxapplication==1). hid-redragon.c driver should not cause this device to be ignored. It appears to me that this problematic change was made late in the commits patch set as a clean up. As there are many different devices being intercepted by the new hid-redragon driver, and as the bytes x81 x00 are not rare in this context, I also think it's advisable to improve the verification condition before performing the report-description patch only meant for the Redragon Asura Keyboard. These two patches will follow. The first restores the function of my keyboard sucessfully. I don't have the Redragon Asura Keyboard necessary to test the second patch and it shouldn't be merged until it can be tested by someone who does. John S Gruber (2): HID: redragon: Fix regression in non-Redragon keyboard due to this new driver HID: redragon Add additional verification to rdesc modification quirk drivers/hid/hid-redragon.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html